ZIP 317: Clarify that tx_in/out_total_size exclude tx_in/out_count.#1288
Draft
nuttycom wants to merge 1 commit into
Draft
ZIP 317: Clarify that tx_in/out_total_size exclude tx_in/out_count.#1288nuttycom wants to merge 1 commit into
nuttycom wants to merge 1 commit into
Conversation
The definitions of tx_in_total_size and tx_out_total_size were ambiguous about whether the CompactSize tx_in_count and tx_out_count prefixes that precede the tx_in and tx_out arrays in the encoded transaction are included. A careful reading of the protocol specification implies they are not, but the ZIP did not say so explicitly. This ambiguity led to a bug in an initial implementation attempt. Closes zcash#683. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #683.
The definitions of `tx_in_total_size` and `tx_out_total_size` were
ambiguous about whether the CompactSize `tx_in_count` and
`tx_out_count` prefixes that precede the `tx_in` and `tx_out` arrays
in the encoded transaction are included. A careful reading of the
protocol specification implies they are not, but the ZIP did not say
so explicitly. This ambiguity led to a bug in an initial
implementation attempt (see zcash/zcash#6524, discussion `r1162854449`).
This PR adds an explicit paragraph after the inputs table making the
exclusion unambiguous.
Filed with Claude Code assistance.