Reject duplicate lookup table cell assignments#902
Open
Kuhai9801 wants to merge 1 commit into
Open
Conversation
Kuhai9801
force-pushed
the
table-layouter-duplicate-cell-fix
branch
from
6f86edc to
1f47be5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #901
Reject duplicate assignments to the same lookup-table cell before mutating the
fixed-column assignment backend.
TableLayouter::assign_celldocuments that assigning an already-assigned tablecell returns an error, but only default-row overwrites were rejected. Non-default
duplicate offsets could overwrite the stored fixed value for the same table
cell.
This PR adds the missing duplicate-offset check and regression coverage for both
default-row and non-default-row table overwrites.