Skip to content

Implement variable-length input hashing.#847

Open
71104 wants to merge 1 commit into
zcash:mainfrom
71104:main
Open

Implement variable-length input hashing.#847
71104 wants to merge 1 commit into
zcash:mainfrom
71104:main

Conversation

@71104

@71104 71104 commented Jul 21, 2025

Copy link
Copy Markdown

No description provided.

@str4d str4d left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look fine but I'd prefer to have test vectors.

Additionally, in order for this to be a patch release, it needs to be based on f066ace (the halo2_poseidon 0.1.0 release commit).

Comment thread halo2_poseidon/src/lib.rs
///
/// Domain specified in [ePrint 2019/458 section 4.2](https://eprint.iacr.org/2019/458.pdf).
#[derive(Clone, Copy, Debug)]
pub struct VariableLength;

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there any test vectors available for this configuration?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants