Split ConstraintSystem into a builder type and a verifying key type#781
Draft
str4d wants to merge 1 commit into
Draft
Split ConstraintSystem into a builder type and a verifying key type#781str4d wants to merge 1 commit into
ConstraintSystem into a builder type and a verifying key type#781str4d wants to merge 1 commit into
Conversation
This is an initial refactor performed during Halo 2 Office Hours, to explore the effects of this split on the wider codebase. At the end, we discussed the result, and noted that the verifying key type still contains data in sub-types that is irrelevant to the actual verifying key. The verifying key type is also never exposed in the public API of the verifying key; `ConstraintSystem` was only public for its use in `Circuit::configure`. The likely next steps are: - Rework `PinnedConstraintSystem` to be the verifying key type, only storing the data needed for the transcript, but being an owned type that exposes immutable references via methods instead of its fields being `pub(crate)`. - Undo the `ConstraintSystemBuilder` rename, so we are just removing parts of the `ConstraintSystem` API. - Rework `ConstraintSystem::pinned` and `VerifyingKey::from_parts` to instead become the builder method for the verifying key type along with the data that is cached alongside it inside `VerifyingKey`. - Refactor the very few methods that we identified as only relevant to the verifying key type, as they are only used redundantly.
This was referenced Jun 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an initial refactor performed during Halo 2 Office Hours, to explore the effects of this split on the wider codebase.
At the end, we discussed the result, and noted that the verifying key type still contains data in sub-types that is irrelevant to the actual verifying key. The verifying key type is also never exposed in the public API of the verifying key;
ConstraintSystemwas only public for its use inCircuit::configure.The likely next steps are:
PinnedConstraintSystemto be the verifying key type, only storing the data needed for the transcript, but being an owned type that exposes immutable references via methods instead of its fields beingpub(crate).ConstraintSystemBuilderrename, so we are just removing parts of theConstraintSystemAPI.ConstraintSystem::pinnedandVerifyingKey::from_partsto instead become the builder method for the verifying key type along with the data that is cached alongside it insideVerifyingKey.