interaction with the multiscales convention#25
Open
keewis wants to merge 9 commits into
Open
Conversation
Contributor
Author
|
@maxrjones, any chance you would be able to review this? I'd be particularly interested in feedback on the multiscales interaction and the schema (is this too strict / not strict enough?) Otherwise this should be the last thing to change before publishing the first version of the convention. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
multiscalesconvention #23This gives advice on how to combine the
dggsandmultiscalesconventions for image pyramids on a DGGS.I'm not sure how strict the schema should be so for now it allows
"dggs": {"refinement_level": 8}for layout items that don't also specifyderived_from. If we do want it to be strict, then we'd need to add a condition (usingoneOf) that only allows partial dggs objects ifderived_fromis present.@maxrjones, would you have some time to review this? I'd be particularly interested in knowing how strict I should make the schema (
spatial's schema is pretty loose, but not sure we want to follow that here), and whether I interpret themultiscalesspec correctly.