bank transfer & balance commands#50
Open
urq wants to merge 3 commits into
Open
Conversation
added 2 commits
July 3, 2018 18:18
This stuff isn't being used anywhere in the codebase, so get rid of it.
zackhsi
reviewed
Jul 7, 2018
| password = getpass.getpass(prompt='Venmo password [{}]: ' | ||
| .format('*' * 10 if old_password else None)) | ||
| bank_account_id = getpass.getpass( | ||
| prompt='Bank account ID [{}]: '.format( |
Owner
There was a problem hiding this comment.
Can we mark this as clearly optional in the prompt?
Additionally, could we create and link to documentation on how to find this ID?
Author
There was a problem hiding this comment.
Good idea... where do you want documentation to go? We could put it in the root README or somewhere else, and then I could link to it in the Bank account ID prompt. It would be something like the following:
Instructions to get Bank ID
- Navigate to venmo.com in your browser and sign in.
- Click on the "Transfer to Bank" link to bring up the Transfer modal.
- You will see your bank accounts listed in the modal. Right-click on the bank of interest and inspect the HTML element.
- Traverse the parents of the selected DOM node (navigate up the DOM tree) to the first
- tag. It should have a "ba-id" property whose value is a UUID. This is your bank ID.
Owner
There was a problem hiding this comment.
The root README in the setup section makes sense. Yup, clear instructions 👍
|
|
||
| # OAuth | ||
| CLIENT_ID = '2667' | ||
| CLIENT_SECRET = 'srDrmU3yf452HuFF63HqHEt25pa5DexZ' |
This command allows the user to transfer an amount from their venmo balance into one of their already-registered bank accounts. To support this, a new configuration parameter for the bank account ID has been added to the `configure` command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.