Release v3.4.1#24
Merged
Merged
Conversation
Was triggering on push/PR with a broken kelleyk/emacs PPA (404 on ubuntu-noble) and a stale ./run-tests.sh path. Real CI is test.yml; this workflow only exists for local act iteration. Restricted to workflow_dispatch and aligned with test.yml's setup steps. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Stub defvar `--ecc-auto-response-responses nil` in retry.el and core.el pre-bound the variable. When test files load alphabetically under C locale (CI), test-ecc-auto-response-retry.el runs first and pulls in the stub, leaving the var bound to nil. The subsequent defcustom in ecc-auto-response.el then refuses to overwrite the bound value, so :waiting / :y/n entries vanish from the alist at test time. Convert the stubs to bare forward declarations (defvar SYMBOL with no initial value) so they no longer shadow the real defcustom. Tests now pass 260/260 under LC_ALL=C, matching CI ordering. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Patch release fixing CI test failures and the broken
test-localworkflow.defvar --ecc-auto-response-responses nilin retry.el / core.el shadowed the realdefcustom, causing:y/nand:waitingto vanish from the alist when test files loaded under C locale (CI). Converted to bare forward declarations.test-local.ymlworkflow restricted toworkflow_dispatch(was failing on every push due to a stale kelleyk PPA on Ubuntu 24.04 + outdated script path).Test plan
LC_ALL=C bash tests/run_tests.sh→ 260/260 pass locally🤖 Generated with Claude Code