Skip to content

Fix CI test failures (Emacs 28 compat, state pollution, log visibility) #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ywatanabe1989 merged 1 commit into from
Mar 21, 2026
Merged

Fix CI test failures (Emacs 28 compat, state pollution, log visibility) #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/run_tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ EOF
fi

TEST_OUTPUT_FILE="$THIS_DIR/.test_output_temp.log"
eval $emacs_cmd 2>&1 | tee -a $LOG_PATH >$TEST_OUTPUT_FILE
eval "$emacs_cmd" 2>&1 | tee -a "$LOG_PATH" | tee "$TEST_OUTPUT_FILE"
TEST_EXIT_CODE=${PIPESTATUS[0]}

if [ $TEST_EXIT_CODE -eq 0 ]; then
Expand Down
1 change: 1 addition & 0 deletions tests/test-ecc-require-integrity.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
;;; Prevents issue #20: missing files that break loading for users.

(require 'ert)
(require 'subr-x) ; string-empty-p is in subr-x on Emacs 28, subr.el on Emacs 29+

(defun test-ecc-require--find-project-root ()
"Find project root by locating the src/ directory.
Expand Down
6 changes: 4 additions & 2 deletions tests/test-ecc-tab-highlight.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,10 @@
(should (functionp 'ecc-tab-highlight--restore)))

(ert-deftest test-ecc-tab-highlight-active-initially-nil ()
"Active flag should be nil initially."
(should-not ecc-tab-highlight--active))
"Active flag should be nil initially.
Uses let-binding to isolate from global state set by other tests."
(let ((ecc-tab-highlight--active nil))
(should-not ecc-tab-highlight--active)))

(ert-deftest test-ecc-tab-highlight-compute-face-no-buffers ()
"Compute face should return nil when no registered buffers."
Expand Down
Loading