[cqlsh] Add environment variable to validate server hostname#10
Open
iSignal wants to merge 1 commit into
Open
Conversation
39ca999 to
dbc879e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change adds the ability for ycqlsh to check the server certificate to verify that it matches the connection hostname. Verification is still disabled by default but can be enabled by using the SSL_CHECK_HOSTNAME env var or an equivalent cqlsh entry.
Test Plan
Start a yugabyte cluster with client cert CN set to 127.0.0.1 and server listening on 127.0.0.1. Also forward connections from 127.0.0.2:9042 to 127.0.0.1:9042 by using an ssh tunnel. This way, connections to 127.0.0.1 should pass server cert verification but conns to 127.0.0.2 should fail.
For all cases below, set
export SSL_CERTFILE=<ca.crt>Test cases
/usr/bin/python3 ~/code/cqlsh/bin/ycqlsh.py --ssl 127.0.0.2 9042succeeds with no env vars as before.SSL_CHECK_HOSTNAME=true /usr/bin/python3 ~/code/cqlsh/bin/ycqlsh.py --ssl 127.0.0.2 9042fails withSSL_CHECK_HOSTNAME=false/usr/bin/python3 ~/code/cqlsh/bin/ycqlsh.py --ssl 127.0.0.2 9042succeedsSSL_VALIDATE=false SSL_CHECK_HOSTNAME=true /usr/bin/python3 ~/code/cqlsh/bin/ycqlsh.py --ssl 127.0.0.2 9042succeeds