Skip to content

fix: complex images in hero/promo background image#1253

Merged
benlife5 merged 3 commits into
mainfrom
complex-images
Jun 30, 2026
Merged

fix: complex images in hero/promo background image#1253
benlife5 merged 3 commits into
mainfrom
complex-images

Conversation

@benlife5

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

Copy link
Copy Markdown
Contributor

Warning: Component files have been updated but no migrations have been added. See https://github.com/yext/visual-editor/blob/main/packages/visual-editor/src/components/migrations/README.md for more information.

@coderabbitai

coderabbitai Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 8873f266-e62e-445f-84e0-4238e1d31ce8

📥 Commits

Reviewing files that changed from the base of the PR and between ab0a2f1 and 93af2fe.

📒 Files selected for processing (1)
  • packages/visual-editor/src/docs/components.md

Walkthrough

ComplexImageType is added to the @yext/pages-components imports and included in the backgroundImage type unions for HeroData and PromoData. The component documentation is updated to match the new unions. In the hero and promo variant components, localizedImage is given an explicit { url: string; width: number; height: number } | undefined type, and SpotlightPromo adds handling for resolvedBackgroundImage.image.

Suggested Reviewers

  • asanehisa
  • briantstephan
🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No description was provided, so there is no meaningful text to assess. Add a short description of the hero/promo complex-image support and any relevant implementation details.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the main change: supporting complex images in hero and promo background images.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch complex-images

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@benlife5 benlife5 merged commit e1204dc into main Jun 30, 2026
17 checks passed
@benlife5 benlife5 deleted the complex-images branch June 30, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants