Skip to content

feat: add showIncludeCaretField option to StyledLinkField#1245

Merged
briantstephan merged 2 commits into
mainfrom
show-include-caret-field
Jun 29, 2026
Merged

feat: add showIncludeCaretField option to StyledLinkField#1245
briantstephan merged 2 commits into
mainfrom
show-include-caret-field

Conversation

@briantstephan

Copy link
Copy Markdown
Contributor

By default, we will still always show the "Include Caret" field, but this gives us the option to hide it for links where it is not relevant, including the navigation links in the shared header.

@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 63e77e89-eb6f-4f8a-b2bc-561d81c34444

📥 Commits

Reviewing files that changed from the base of the PR and between cafaf4d and 3c4efd6.

📒 Files selected for processing (1)
  • packages/visual-editor/src/fields/styledFields/StyledLinkField.tsx

Walkthrough

StyledLinkField now accepts an optional showIncludeCaretField boolean. The override logic defaults this value to true when it is not provided. The “Include Caret” combobox is only rendered when the flag is truthy.

Possibly related PRs

Suggested reviewers

  • jwartofsky-yext
  • benlife5
  • mkilpatrick
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: adding showIncludeCaretField to StyledLinkField.
Description check ✅ Passed The description matches the change by explaining that Include Caret stays on by default but can now be hidden when irrelevant.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch show-include-caret-field

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

benlife5
benlife5 previously approved these changes Jun 26, 2026
asanehisa
asanehisa previously approved these changes Jun 26, 2026
@yext-bot yext-bot dismissed stale reviews from asanehisa and benlife5 via 5d8815a June 26, 2026 22:30
@briantstephan briantstephan merged commit 9181469 into main Jun 29, 2026
17 checks passed
@briantstephan briantstephan deleted the show-include-caret-field branch June 29, 2026 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants