Skip to content

feat: more tracking#1262

Merged
w84april merged 5 commits into
mainfrom
feat/plausible-upgrade
Jun 12, 2026
Merged

feat: more tracking#1262
w84april merged 5 commits into
mainfrom
feat/plausible-upgrade

Conversation

@w84april

Copy link
Copy Markdown
Collaborator

New events to track:

  • portfolio_tab_select
  • portfolio_history_tab_select
  • portfolio_history_breakdown_click
  • portfolio_history_breakdown_open_vault
  • portfolio_activity_interact

plausible was discussed here - #1201 (review)

@vercel

vercel Bot commented May 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
yearnfi Ready Ready Preview, Comment Jun 11, 2026 7:46pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
yearnfi-nextjs Ignored Ignored Preview Jun 11, 2026 7:46pm
yearnfi-nextjs-2 Ignored Ignored Preview Jun 11, 2026 7:46pm

Request Review

@github-actions

github-actions Bot commented May 29, 2026

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@w84april w84april requested a review from rossgalloway June 8, 2026 14:36

@murderteeth murderteeth left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Request changes: add portfolio→vault click attribution. Two events (matching the per-surface convention like VAULT_CLICK_LIST_ROW / LANDER_VAULT_CLICK):

  • VAULT_CLICK_PORTFOLIO_LIST_ROW — holdings click. VaultsListRow hardcodes VAULT_CLICK_LIST_ROW (VaultsListRow.tsx:502); add an optional clickEventName prop and pass this from the portfolio holdings.
  • VAULT_CLICK_PORTFOLIO_SUGGESTED — suggested click. SuggestedVaultCard has no tracking and is shared with TrendingVaults on /vaults — pass the event as a prop set only from the portfolio, don't hardcode it.

Reviewed using the review-pr skill.

@murderteeth murderteeth left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

Previous review items are resolved — clickEventName works as requested on both VaultsListRow and SuggestedVaultCard. Verified on the Vercel preview.

But the branch now fails bun run test.

Issue

  • SuggestedVaultCard.test.tsx fails

This PR makes SuggestedVaultCard import usePlausible, which pulls the real @plausible-analytics/tracker package into the test. Vitest can't resolve that package (it ships no main/exports), so the test file crashes before running.

Fix by stubbing the hook, same as the other mocks already in the file (verified working):

vi.mock('@hooks/usePlausible', () => ({
  usePlausible: () => vi.fn()
}))

Verdict

REQUEST_CHANGES


How This Was Reviewed

This review was conducted using the review-pr skill.

@w84april w84april merged commit 668d875 into main Jun 12, 2026
14 checks passed
@w84april w84april deleted the feat/plausible-upgrade branch June 12, 2026 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants