Skip to content

Harden server fetch upstreams#1242

Closed
rossgalloway wants to merge 1 commit into
release/26-04-17from
codex/validate-ssrf-fetches
Closed

Harden server fetch upstreams#1242
rossgalloway wants to merge 1 commit into
release/26-04-17from
codex/validate-ssrf-fetches

Conversation

@rossgalloway

Copy link
Copy Markdown
Collaborator

Summary

  • Validate Enso proxy URLs against fixed HTTPS upstream origins and paths before server-side fetches.
  • Reject upstream redirects for Enso and historical price fetches.
  • Validate DefiLlama and yearn-prices historical price requests against their configured HTTPS upstreams.
  • Add regression coverage for blocking non-HTTPS yearn-prices upstreams before fetch.

Validation

  • bun run lint:fix
  • bunx vitest run api/lib/holdings/services/defillama.test.ts
  • bun run tslint
  • bun run build

Constrain Enso and historical price proxy fetches to their expected HTTPS upstreams and reject redirects. Add regression coverage for blocking non-HTTPS yearn-prices upstreams before fetch.
@vercel

vercel Bot commented May 19, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
yearnfi Ready Ready Preview, Comment May 19, 2026 10:00pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
yearnfi-nextjs Ignored Ignored May 19, 2026 10:00pm

Request Review

@github-actions

github-actions Bot commented May 19, 2026

Copy link
Copy Markdown

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@rossgalloway

Copy link
Copy Markdown
Collaborator Author

Closing this PR because it has been superseded by the grouped remediation flow.

The Enso server-fetch side is now covered by the grouped Enso remediation. The DefiLlama-specific concern was disproven in later validation, so it is intentionally not carried forward as a fix branch.

Replacement:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant