Repository navigation
docs(sdk): state which commit CI.CommitSha and the PR context each record (#233) - #237
Merged
Merged
Conversation
…cord (#233) CI.CommitSha is the commit the build tested (a merge commit on most PR builds); PullRequestContext.CommitSha is the PR head the author pushed. Xping Cloud keys a PR run by the head and uses CI.CommitSha only when CI.IsPullRequest is false. The XML docs on both and ci-cd-setup.md now say so, and tests pin CI.CommitSha to the built commit on GitHub pull_request, Azure Pipelines PR and GitLab merged-results builds, and to the pushed commit on GitHub push. No behavior change. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #233.
PullRequestContext.CommitShais the PR head;EnvironmentInfo.CustomPropertiesdocumentsCI.CommitSha(commit the build tested) andCI.IsPullRequest, plus the precedence rule Xping Cloud follows.ci-cd-setup.md: new Which Commit Is Recorded section with the per-platform table; the GitHub, Azure and GitLab metadata lists link to it.CI.CommitShais the built (merge) commit on GitHubpull_request, Azure Pipelines PR and GitLab merged-results builds, even with the head variable set; it is the pushed commit on GitHubpush.pull_request_targetomission was already covered.🤖 Generated with Claude Code