fix(semantic-tokens): split multiline tokens one per line#8
Merged
Conversation
The LSP spec requires that semantic tokens do not span line boundaries. Block comments (/* */ and /** */) were emitted as a single token covering the full text length, so clients clamped the token to the first line and left continuation lines un-highlighted. Introduce AstVisitor::emitSplitting() which detects newlines in the raw token text and delegates to emit() once per physical line with a line-scoped length. Single-line tokens take the existing fast path unchanged. Handles \r\n line endings by stripping the trailing \r before computing each line's length. Add unit tests asserting per-line coverage and the general no-token-spans- multiple-lines invariant, plus a Behat scenario that exercises the fix end-to-end through the live LSP server. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LSP spec requires that semantic tokens do not span line boundaries. Block comments (/* / and /* */) were emitted as a single token covering the full text length, so clients clamped the token to the first line and left continuation lines un-highlighted.
Introduce AstVisitor::emitSplitting() which detects newlines in the raw token text and delegates to emit() once per physical line with a line-scoped length. Single-line tokens take the existing fast path unchanged. Handles \r\n line endings by stripping the trailing \r before computing each line's length.
Add unit tests asserting per-line coverage and the general no-token-spans- multiple-lines invariant, plus a Behat scenario that exercises the fix end-to-end through the live LSP server.