fix(ps): restore --all flag to scan all containers#24
Merged
Conversation
PR #21 removed the `--all` branch from `devcontainer ps`, leaving the flag silently consumed by `shift`. As a result `ps` and `ps --all` produced identical output, even though completions still advertised `--all`. Restore the `--all` branch so it scans every running Docker container and reports those with active claude sessions, while the default keeps listing only this project's containers. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
devcontainer psanddevcontainer ps --allcurrently produce identical output. PR fix(ps): list running project containers instead of counting claude processes #21 removed the--allbranch from thepscommand, after which the flag was silently consumed byshiftand ignored — even though shell completions still advertise it.--allbranch: it scans every running Docker container and reports only those with active claude sessions. The defaultpsis unchanged — it still lists this project's containers (filtered byname=^${PROJECT}-dev-) with per-container session counts.((++count))) from fix(ps): use pre-increment to avoid set -e crash #22 and updated the--helptext. No completions change needed; they already listedps --all.Test plan
devcontainer ps— lists only this project's containers with session countsdevcontainer ps --all— lists all running containers (across projects) that have a claude session; differs from plainpswhen other projects are runningdevcontainer ps --allwith no claude sessions anywhere — prints0 containers running🤖 Generated with Claude Code