fix(dev): improve argument validation and fix filter typo in dev scripts#2008
Open
alelpoan wants to merge 3 commits into
Open
fix(dev): improve argument validation and fix filter typo in dev scripts#2008alelpoan wants to merge 3 commits into
alelpoan wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix three bugs in dev scripts that cause silent failures or incorrect behavior.
Changes:
register-enable-node.sh: missing argument count check causes unbound variable errors, added
[[ $# -ne 4 ]]guard with usage and exampledev/gen/migration: missing
$1check allows empty migration name to be passed to migrate create, added guard with usage and exampledev/test:
'pkg/mock'→'pkg/mocks'— filter never matched real path, causing mock packages to be included in test runsTest plan:
./dev/cmd/register-enable-node.shwith no args prints usage and exits cleanly./dev/gen/migrationwith no args prints usage and exits cleanlydev/testnow correctly excludespkg/mockspackages from test runsNote
Fix filter typo and add argument validation to dev scripts
pkg/mocktopkg/mocksso the correct packages are excluded when generating the test package list.Macroscope summarized 0b724a5.