Skip to content

close: wrap {{Findsources}} into request itself instead of comment #358

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Xi-Plus merged 1 commit into from
Dec 13, 2025
Merged

close: wrap {{Findsources}} into request itself instead of comment #358

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion modules/twinkleclose.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -768,7 +768,15 @@ Twinkle.close.callbacks = {
var params = pageobj.getCallbackParameters();

var lines = params.text.replace(/<!-- Twinkle:.+-->\n?/, '').trim().split('\n');

var findsourcesPos = lines.findIndex(line => line.includes('{{Findsources'));
// we assume that no one will leave msg between title and {{Findsources}}, or some msgs will disappear
// and on a basis of that, actually we can use ... ? 2 : 1 here
var slicePos = findsourcesPos !== -1 ? findsourcesPos + 1 : 1;
var appendText = '\n{{safesubst:SafeAfdHead}}\n' + lines[0] + '\n';
if (findsourcesPos !== -1) {
appendText += lines[findsourcesPos] + '\n\n';
}
if (params.batchText) {
var bar = params.batchText.split('\n----\n');
var comment = bar[bar.length - 1];
Expand All @@ -779,7 +787,7 @@ Twinkle.close.callbacks = {
Morebits.Status.warn(conv({ hans: '信息', hant: '資訊' }), conv({ hans: '无法解析批量提删理据', hant: '無法解析批量提刪理據' }));
}
}
appendText += lines.slice(1).join('\n') + '\n{{subst:Relist';
appendText += lines.slice(slicePos).join('\n') + '\n{{subst:Relist';
if (params.comment) {
appendText += '|1=' + params.comment;
}
Expand Down
Loading