Skip to content

Fix/ Missing fixes from 2.3 release#1427

Merged
maks merged 1 commit into
xiphonics:masterfrom
alexbonhomme:fix/missing-fixes-from-2.3
May 28, 2026
Merged

Fix/ Missing fixes from 2.3 release#1427
maks merged 1 commit into
xiphonics:masterfrom
alexbonhomme:fix/missing-fixes-from-2.3

Conversation

@alexbonhomme

@alexbonhomme alexbonhomme commented May 21, 2026

Copy link
Copy Markdown
Contributor

Hey !

I was working on the master branch and I've noticed that some commits may be missing from the 2.3-release.

The second one seems to fix a crash during sample loading on my hw. I may have misunderstand something, but it's worth check it I suppose :)

BTW thanks for you work 🙏
I'm working on rp2350 compatibility so I will send you another PR about that in the incoming weeks if your interested :)

@maks

maks commented May 21, 2026

Copy link
Copy Markdown
Contributor

Thanks for spotting and fixing that @alexbonhomme
Could you please remove the user manual changes as the user manual for the advance is now being updated in a private repo alongside the advance firmware, so I will making an update from that repo to here once the next Advance firmware is released as stable. The code change was however missed from being cherry picked from the release branch into master so thanks for spotting that 👍🏻

@maks

maks commented May 21, 2026

Copy link
Copy Markdown
Contributor

@alexbonhomme on the RP2350 front, please discuss this in either the discord or in a new issue here as we need to be clear about what you are planning on wanting to contribute.

@alexbonhomme alexbonhomme force-pushed the fix/missing-fixes-from-2.3 branch from 37df82b to db0144c Compare May 22, 2026 11:56
@alexbonhomme

alexbonhomme commented May 22, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for spotting and fixing that @alexbonhomme Could you please remove the user manual changes as the user manual for the advance is now being updated in a private repo alongside the advance firmware, so I will making an update from that repo to here once the next Advance firmware is released as stable. The code change was however missed from being cherry picked from the release branch into master so thanks for spotting that 👍🏻

Done ! :)

@alexbonhomme

Copy link
Copy Markdown
Contributor Author

@alexbonhomme on the RP2350 front, please discuss this in either the discord or in a new issue here as we need to be clear about what you are planning on wanting to contribute.

You're absolutely right I should've introduced my self on discord ! I will :)

@maks maks left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@maks maks merged commit 1a1c220 into xiphonics:master May 28, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants