You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Thanks for spotting and fixing that @alexbonhomme
Could you please remove the user manual changes as the user manual for the advance is now being updated in a private repo alongside the advance firmware, so I will making an update from that repo to here once the next Advance firmware is released as stable. The code change was however missed from being cherry picked from the release branch into master so thanks for spotting that 👍🏻
@alexbonhomme on the RP2350 front, please discuss this in either the discord or in a new issue here as we need to be clear about what you are planning on wanting to contribute.
Thanks for spotting and fixing that @alexbonhomme Could you please remove the user manual changes as the user manual for the advance is now being updated in a private repo alongside the advance firmware, so I will making an update from that repo to here once the next Advance firmware is released as stable. The code change was however missed from being cherry picked from the release branch into master so thanks for spotting that 👍🏻
@alexbonhomme on the RP2350 front, please discuss this in either the discord or in a new issue here as we need to be clear about what you are planning on wanting to contribute.
You're absolutely right I should've introduced my self on discord ! I will :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey !
I was working on the master branch and I've noticed that some commits may be missing from the 2.3-release.
The second one seems to fix a crash during sample loading on my hw. I may have misunderstand something, but it's worth check it I suppose :)
BTW thanks for you work 🙏
I'm working on rp2350 compatibility so I will send you another PR about that in the incoming weeks if your interested :)