Reload pool sample after editor save-as#1398
Open
maks wants to merge 8 commits into
Open
Conversation
maks
force-pushed
the
1384-reload-pool-sample-after-edit
branch
from
9bf83d3 to
09fceab
Compare
maks
changed the title
maks
force-pushed
the
1384-reload-pool-sample-after-edit
branch
from
d5df2d5 to
172a955
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After doing a "save-as" save operation in the Sample Editor for a sample in the sample pool, the new sample file needs to be loaded into the project.
Also need to add checks that doing the save-as will not exceed project pool size limits and not overwrite existing pool file.
Fixes: #1384