fix(chat): use the editor monospace for conversation code - #810
Open
Frank-zhu0404 wants to merge 1 commit into
Open
Frank-zhu0404 wants to merge 1 commit into
Frank-zhu0404 wants to merge 1 commit into
Conversation
Fenced blocks, inline code, and CodeBlock followed Tailwind's default mono stack. On macOS and Chinese Windows the generic monospace face paints Han glyphs as Songti, which is what xintaofei#761 is looking at. The editor face is now published as --font-code (prehydrated from the stored stack, same path as --font-sans). Conversation code uses that stack with the trailing generic monospace replaced by CJK UI faces, so Latin stays on the settings mono and Han no longer falls through to Songti. Monaco and the terminal keep their own stacks, and the rest of the UI's font-mono is unchanged. Closes xintaofei#761
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fenced blocks, inline code, and
CodeBlockfollowed Tailwind's default mono stack. On macOS and Chinese Windows the generic monospace face paints Han glyphs as Songti, which is what #761 is looking at.The editor face is now published as
--font-code(prehydrated from the stored stack, same path as--font-sans). Conversation code uses that stack with the trailing genericmonospacereplaced by CJK UI faces, so Latin stays on the settings mono and Han no longer falls through to Songti. Monaco and the terminal keep their own stacks, and the rest of the UI'sfont-monois unchanged.Testing
pnpm lint .→ exit 0pnpm test→ 501 files / 7383 tests passed--font-codepublication / appearance script, font-presets CJK stack helper, appearance-provider wiringCloses #761