Repository navigation
Build with rypt SDK v0.2.0 - #2
Merged
Merged
Conversation
rypt v0.2.0 allows plain http in WithBaseURL only to the addresses 127.0.0.1 and ::1, and refuses the name localhost, because a name is looked up and DNS could send the token to another machine. https://localhost still works. newRyptForTest now passes the httptest URL (http://127.0.0.1:<port>) unchanged instead of swapping in localhost, and the transport-failure case uses http://127.0.0.1:1, so it still reaches the Outage classification through a refused connection. The new TestRyptRefusesPlainHTTPToLocalhost records that rypt-store relies on the SDK for this refusal, while 127.0.0.1, [::1] and https://localhost still work. rypt.go and docs/GAPS.md name v0.2.0; the three listed gaps are unchanged in this release. go mod tidy also drops four stale moby/* go.sum lines that were already unused on main. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NYjhaGCRVp9GXLUuUZv8g1
Go 1.27.2's crypto/x509 does not distrust a set of compromised intermediate certificates (GO-2026-6809, CVE-2026-111943), and govulncheck reports that FinishLogin reaches x509.Certificate.Verify through the WebAuthn library, so CI fails. Go 1.27.3 fixes it. Move both pins: the toolchain line in go.mod, and the golang image in the Dockerfile, which sets GOTOOLCHAIN=local and so ignores go.mod.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rypt SDK v0.2.0 (x6c-co/rypt#5) allows plain
httponly to127.0.0.1and::1, and refuses the namelocalhost. A name is looked up, and DNS could send the token to another machine.https://localhoststill works.Changes
go.mod:github.com/x6c-co/ryptv0.1.0 → v0.2.0.go mod tidyalso drops four stalemoby/*lines fromgo.sum, which were already unused on main.newRyptForTestpasses the httptest URL (http://127.0.0.1:<port>) unchanged, instead of swapping inlocalhost.http://127.0.0.1:1, so it still reaches the Outage classification through a refused connection.TestRyptRefusesPlainHTTPToLocalhost: rypt-store relies on the SDK to refusehttp://localhost, while127.0.0.1,[::1]andhttps://localhoststill work.rypt.goanddocs/GAPS.mdname v0.2.0. The three listed gaps are unchanged in this release.crypto/x509does not distrust a set of compromised intermediate certificates, andFinishLoginreachesx509.Certificate.Verifythrough the WebAuthn library. Go 1.27.3 fixes this. The commit moves thetoolchainline ingo.modand thegolangimage in the Dockerfile; the image setsGOTOOLCHAIN=local, so it ignoresgo.mod. The image published frommainon 2026-10-16 was built with 1.27.2.Tests
gofmt,go vet,go test -race ./...(14 packages) and govulncheck pass on Go 1.27.3. CI in this repo has not started on pushes or PRs, so it was started by hand on this branch. The changed tests passed 3 runs in a row. A second agent reviewed the diff and found no problems. Nothing in the server config, docs or deploy files passed a plain-httplocalhostURL to the SDK.🤖 Generated with Claude Code
https://claude.ai/code/session_01NYjhaGCRVp9GXLUuUZv8g1