Repository navigation
Conversation
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 50 minutes. View limit details
No actionable comments were generated in the recent review. WalkthroughThe Apple camera provider now clears its capture object when opening fails. A macOS regression test checks repeated authorization denial from a worker thread. Rust device enumeration and ARM64 QEMU installation are also updated. ChangesApple camera open and authorization test
Rust device iteration
ARM64 test emulation setup
Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Suggested reviewers: Merge Risk:
|
Summary
A failed macOS camera open leaves the provider holding its internal camera object, so a subsequent open on the same provider fails as if a camera were already open. Clean up that object on failure so the caller can retry.
Add a macOS regression test exercising the real provider with mocked authorization. It checks that an off-main-thread request completes without servicing the main queue and that a denied request does not prevent a subsequent attempt.
Validation
Follow-up to #56.
Summary by CodeRabbit