fix(admin): json-viewer element tag mismatch (rendered empty)#39
Merged
Conversation
@andypf/json-viewer registers <andypf-json-viewer>, not <json-viewer>; the unknown tag rendered as an empty element so detail pages showed only the label. Also drop show-toolbar (not an attribute in 2.1.1) for show-copy. Regression test extracts the customElements.define tag from the vendored bundle and asserts the formatter emits exactly that tag. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vendored @andypf/json-viewer bundle registers
<andypf-json-viewer>; the formatter emitted<json-viewer>— an unknown element with no children, so detail pages showed only the bold label (script loaded fine). Emit the registered tag, swap unsupportedshow-toolbarforshow-copy, and add a regression test that greps thecustomElements.definetag out of the vendored bundle and asserts the formatter emits exactly that tag.207 tests pass.
🤖 Generated with Claude Code