Skip to content

Fix travis builds#40

Open
Oscil8 wants to merge 3 commits into
wvanbergen:masterfrom
Oscil8:fix-travis
Open

Fix travis builds#40
Oscil8 wants to merge 3 commits into
wvanbergen:masterfrom
Oscil8:fix-travis

Conversation

@Oscil8

@Oscil8 Oscil8 commented May 14, 2019

Copy link
Copy Markdown

Old versions of Go are no longer supported by errcheck. It is documented as requiring Go 1.9.

Oddly, I am seeing builds failing on Go 1.9 and 1.10 but succeeding on 1.11 and newer. The build errors for 1.10 are:

0.02s$ make errcheck
errcheck ./...
error: failed to check packages: unsupported version of go: exit status 2: flag provided but not defined: -compiled
usage: list [-e] [-f format] [-json] [build flags] [packages]
Run 'go help list' for details.
make: *** [errcheck] Error 2
The command "make errcheck" exited with 2.

and for go 1.9 it lists usage information for the go list tool rather than just suggesting details.

Ariel Salomon added 3 commits May 14, 2019 12:07
@Oscil8

Oscil8 commented May 14, 2019

Copy link
Copy Markdown
Author

Interesting; no idea why the builds against the pull request are failing but the same commits build in Travis on my branch: https://travis-ci.org/Oscil8/kazoo-go/builds

@Oscil8

Oscil8 commented May 15, 2019

Copy link
Copy Markdown
Author

I filed an upstream bug on errcheck about support for 1.9, 1.10 which seems to have been broken recently: kisielk/errcheck#167

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant