Fix travis builds#40
Open
Oscil8 wants to merge 3 commits into
Open
Conversation
added 3 commits
May 14, 2019 12:07
Note: errcheck is failing oddly for go 1.9 and 1.10 as well
Author
|
Interesting; no idea why the builds against the pull request are failing but the same commits build in Travis on my branch: https://travis-ci.org/Oscil8/kazoo-go/builds |
Author
|
I filed an upstream bug on errcheck about support for 1.9, 1.10 which seems to have been broken recently: kisielk/errcheck#167 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old versions of Go are no longer supported by errcheck. It is documented as requiring Go 1.9.
Oddly, I am seeing builds failing on Go 1.9 and 1.10 but succeeding on 1.11 and newer. The build errors for 1.10 are:
and for go 1.9 it lists usage information for the
go listtool rather than just suggesting details.