Skip to content

Adds protocol support to brokers #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
masihyeganeh wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Adds protocol support to brokers #39

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
01375ad
Adds protocol support to brokers
masihyeganeh Apr 17, 2019
9946913
Update kazoo.go
masihyeganeh Apr 18, 2019
de9f0e5
Update kazoo.go
masihyeganeh Apr 18, 2019
0aa7399
Update kazoo.go
masihyeganeh Apr 18, 2019
9a5b2c1
Update kazoo.go
masihyeganeh Apr 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions kazoo.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,9 @@ type Config struct {
// The chroot the Kafka installation is registerde under. Defaults to "".
Chroot string

// The protocol (PLAINTEXT, EXTERNAL, ...). Defaults to "".
Protocol string

// The amount of time the Zookeeper client can be disconnected from the Zookeeper cluster
// before the cluster will get rid of watches and ephemeral nodes. Defaults to 1 second.
Timeout time.Duration
Expand All @@ -63,6 +66,7 @@ type Config struct {
// NewConfig instantiates a new Config struct with sane defaults.
func NewConfig() *Config {
return &Config{
Protocol: "",
Timeout: 1 * time.Second,
Logger: zk.DefaultLogger,
}
Expand Down Expand Up @@ -108,11 +112,17 @@ func (kz *Kazoo) Brokers() (map[int32]string, error) {
}

type brokerEntry struct {
Host string `json:"host"`
Port int `json:"port"`
ListenerSecurityProtocolMap map[string]string `json:"listener_security_protocol_map"`
Endpoints []string `json:"endpoints"`
JmxPort int `json:"jmx_port"`
Host string `json:"host"`
Timestamp string `json:"timestamp"`
Port int `json:"port"`
Version int `json:"version"`
}

result := make(map[int32]string)
children:
for _, child := range children {
brokerID, err := strconv.ParseInt(child, 10, 32)
if err != nil {
Expand All @@ -129,6 +139,16 @@ func (kz *Kazoo) Brokers() (map[int32]string, error) {
return nil, err
}

if kz.conf.Protocol != "" {
protocol := strings.ToUpper(kz.conf.Protocol)
for _, endpoint := range brokerNode.Endpoints {
if strings.Index(endpoint, protocol) == 0 {
result[int32(brokerID)] = strings.Replace(endpoint, protocol+"://", "", 1)
continue children
}
}
}

result[int32(brokerID)] = fmt.Sprintf("%s:%d", brokerNode.Host, brokerNode.Port)
}

Expand Down