fix for KAFKA-3645#23
Open
rickyspeak wants to merge 1 commit into
Open
Conversation
wvanbergen
requested changes
Sep 30, 2016
wvanbergen
left a comment
wvanbergen
left a comment
Owner
There was a problem hiding this comment.
Just some error handling questions, but this is a nice improvement. 👍
| } | ||
|
|
||
| if len(brokerEP.Endpoints) == 0 { | ||
| return nil, err |
Owner
There was a problem hiding this comment.
You cannot use err here; you'll need the create your own error value to return for this scenario.
| // take first endpoint in the list as the only valid host | ||
| listenerTokens := strings.SplitN(brokerEP.Endpoints[0], "://", 2) | ||
| if len(listenerTokens) < 2 { | ||
| return nil, err |
Owner
|
Also, can you add a test for the new behavior? It looks like Travis didn't run CI on this pull request. This issue should be fixed now when you push again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/KAFKA-3645
I have a feature branch for doing SASL/Kerberos and this bug crept up. Here is a solution for this bug until 0.10.1 comes out.