compatible with native java/scala consumer id registration format#18
Open
funkygao wants to merge 12 commits into
Open
compatible with native java/scala consumer id registration format#18funkygao wants to merge 12 commits into
funkygao wants to merge 12 commits into
Conversation
in java/scala kafka implementation, the Timestamp of a consumer is string instead of int64
Owner
|
What version of the Scala implementation are you basing this on? The schema I am using was definitely the schema around 0.8.2. |
Owner
|
Also, it looks like Travis didn't run CI on this pull request. This issue should be fixed now. Can you rebase this PR and try again? |
wvanbergen
requested changes
Sep 30, 2016
wvanbergen
left a comment
wvanbergen
left a comment
Owner
There was a problem hiding this comment.
Couple of questions, but if you address them I will merge.
| func (cg *Consumergroup) NewInstance() *ConsumergroupInstance { | ||
| id, err := generateConsumerInstanceID() | ||
| return cg.NewInstanceRealIp("") | ||
| } |
Owner
There was a problem hiding this comment.
Would this method be deprecated now?
| assert.Equal(t, nil, err) | ||
| t.Logf("%+v", id) | ||
| } | ||
| } |
Owner
There was a problem hiding this comment.
What is the purpose of this test?
|
|
||
| func TestGenerateConsumerInstanceID(t *testing.T) { | ||
| for i := 0; i < 5; i++ { | ||
| id, err := generateConsumerInstanceID() |
Owner
There was a problem hiding this comment.
Doesn't this function require an argument now?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
in java/scala kafka implementation, the Timestamp of a consumer
is string instead of int64