Repository navigation
Conversation
…ord once An aggregate filtered through a to-many relationship must aggregate each matching record once, however many of its related rows match, and conditions on one relationship must hold for the same related row. The lateral strategy currently counts a record once per matching related row; these tests pass with the AshSQL fix (ASH_SQL_VERSION=local).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression tests for aggregates that count a record once per matching related row when their filter references a to-many relationship. The fix is in AshSQL: wtsnz/ash_sql#12.
What they check
A post has three comments:
ratings.score > 5(the first through two ratings, the second through one);The tests check that:
count,sumof likes andlistof likes throughratings.score > 5return 2, 4 and[2, 2];ratings.score > 8 and ratings.score < 10only matches the first comment, since both conditions must hold for the same rating;ratings.score > 7 or likes == 7sums to 11, counting each comment once.Results
orsum is 13.ASH_SQL_VERSION=local): they pass. The full suite fails the same 39 tests asmainin the local test database, and nothing new.This PR depends on that AshSQL fix being released.
Found by
The data-layer conformance suite (wtsnz/ash#7), gap
filter-fanout.