Repository navigation
Conversation
A list aggregate leaves out nil values unless include_nil? is true, with or without a sort. The unsorted case currently keeps them, in AshSQL's lateral strategy; these tests pass with that fix (ASH_SQL_VERSION=local).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regression test for
listaggregates without a sort includingnilvalues. The fix is in AshSQL: wtsnz/ash_sql#11.What it checks
A post has comments titled
"bbb",nil,"aaa"and"aaa", one of them with no likes. An unsorted query-levellistaggregate of their titles must return:["aaa", "aaa", "bbb"]by default;["aaa", "bbb"]withuniq?: true;["aaa", "bbb"]with its own filter (likes > 0);include_nil?: true.The list has no sort, so the test compares each result sorted.
Results
[nil, "aaa", "aaa", "bbb"]by default.ASH_SQL_VERSION=local): it passes. The full suite has the same 39 failures asmainin the local test database, and nothing new.This PR depends on that AshSQL fix being released.
Found by
The data-layer conformance suite (wtsnz/ash#7), gap
unsorted-list-nil.