feat: WIP-103 make nonce part of the authenticator sig#656
Open
paolodamico wants to merge 9 commits into
Open
Conversation
dkales
previously approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
noncein the message signature.Motivation
noncein the signature, a single signature can be replayed and long lived which presents a security risk.Notes
ACIR opcodes increased from 25730 to 26059
Note
High Risk
Changes WIP-103 cryptographic binding and proof generation semantics (breaking for any party still using the old signature message), and makes ownership-proof builds depend on a pinned
nargotoolchain instead of trusted prebuilt artifacts.Overview
WIP-103 ownership proof now ties the authenticator EdDSA signature to the verifier’s nonce: signing and circuit verification use
Poseidon2(b"WIP103", expected_commitment, nonce)instead of signing the baresub/commitment. The Noir circuit separates commitment (H_CS(leafIndex, blinder)) from the signed message, exposes the commitment as the proved public output, and documents the change inwip-103.md.Authenticator and tests (
prove_credential_sub, proof crate fixtures) hash withDS_OWNERSHIP_PROOFbefore signing so prover, authenticator, and spec stay aligned.Build and release tooling drops committed/downloaded Noir
ownership_proof.pkp/pkvfrom circuit artifact releases and removestools/generate-noir-artifactsandjust build-noir-artifacts. Withzk-ownership-prove/zk-ownership-verify,crates/proof/build.rsrunsnargo compileand provekit to emit keys intoOUT_DIR(requires nargo v1.0.0-beta.11).Reviewed by Cursor Bugbot for commit 03a679a. Bugbot is set up for automated code reviews on this repo. Configure here.