Add ntdotjsx.site to webring #326
Conversation
📝 WalkthroughWalkthroughIn ChangesWebring Member Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Warning |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@index.html`:
- Around line 484-486: The PR adds the new ntdotjsx.site entry but does not
remove the old me.oreshi.com entry, making this an append rather than a
replacement. Locate and delete the entire li element block for me.oreshi.com
(which contains the href to me.oreshi.com) to complete the replacement as
intended. Ensure only the ntdotjsx.site li block remains after the deletion.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
| <li data-lang="th" id="ntdotjsx.site" data-owner="ntdotjsx"> | ||
| <a href="https://ntdotjsx.site">ntdotjsx.site</a> | ||
| </li> |
There was a problem hiding this comment.
Remove the old me.oreshi.com <li> to complete the replacement.
This PR adds ntdotjsx.site correctly, but me.oreshi.com is still present at Line 481-483, so the change is an append, not a replacement. Please delete the entire old <li> block to match the intended update and avoid stale entries.
Suggested fix
- <li data-lang="th" id="me.oreshi.com" data-owner="somboytiger">
- <a href="https://me.oreshi.com">me.oreshi.com</a>
- </li>
<li data-lang="th" id="ntdotjsx.site" data-owner="ntdotjsx">
<a href="https://ntdotjsx.site">ntdotjsx.site</a>
</li>As per coding guidelines, “Remove identified entries from index.html by deleting the entire <li> elements for each site during cleanup,” and this PR objective explicitly describes a replacement.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@index.html` around lines 484 - 486, The PR adds the new ntdotjsx.site entry
but does not remove the old me.oreshi.com entry, making this an append rather
than a replacement. Locate and delete the entire li element block for
me.oreshi.com (which contains the href to me.oreshi.com) to complete the
replacement as intended. Ensure only the ntdotjsx.site li block remains after
the deletion.
Source: Coding guidelines
Added my personal website to the webring.
Website: https://ntdotjsx.site/
GitHub username: ntdotjsx
Webring icon location:
Desktop: Navbar
Mobile: Left Dock
Summary by CodeRabbit