Skip to content

Add ntdotjsx.site to webring #326

Open
ntdotjsx wants to merge 1 commit into
wonderfulsoftware:mainfrom
ntdotjsx:main
Open

Add ntdotjsx.site to webring #326
ntdotjsx wants to merge 1 commit into
wonderfulsoftware:mainfrom
ntdotjsx:main

Conversation

@ntdotjsx

@ntdotjsx ntdotjsx commented Jun 20, 2026

Copy link
Copy Markdown

Added my personal website to the webring.

Website: https://ntdotjsx.site/
GitHub username: ntdotjsx

Webring icon location:

Desktop: Navbar
Mobile: Left Dock

Summary by CodeRabbit

  • Chores
    • Updated a link entry in the ring list with a new destination.

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 20, 2026
@coderabbitai

coderabbitai Bot commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

In index.html, the ol#ring list item previously referencing me.oreshi.com is replaced with a new entry for ntdotjsx.site, updating the element's id, anchor href, and owner attribute accordingly.

Changes

Webring Member Update

Layer / File(s) Summary
Replace webring list item
index.html
The <li id="me.oreshi.com"> entry with its link to https://me.oreshi.com is replaced by <li id="ntdotjsx.site"> pointing to https://ntdotjsx.site with an updated owner attribute.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • dtinth

Poem

A bunny hops through the webring with glee, 🐇
Out goes one site, in comes a new spree,
ntdotjsx.site joins the chain,
Linked paw to paw in the HTML lane,
The webring grows, hop along with me! 🌐

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title directly describes the main change: adding ntdotjsx.site to the webring, which aligns with the primary modification in the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Warning

⚠️ This pull request has been flagged as potential spam (promotional) by CodeRabbit slop detection and should be reviewed carefully.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@index.html`:
- Around line 484-486: The PR adds the new ntdotjsx.site entry but does not
remove the old me.oreshi.com entry, making this an append rather than a
replacement. Locate and delete the entire li element block for me.oreshi.com
(which contains the href to me.oreshi.com) to complete the replacement as
intended. Ensure only the ntdotjsx.site li block remains after the deletion.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 87a3af4d-5cbb-4e8e-b841-a4ab2abdbb8e

📥 Commits

Reviewing files that changed from the base of the PR and between e4657f9 and 3b31773.

📒 Files selected for processing (1)
  • index.html

Comment thread index.html
Comment on lines +484 to +486
<li data-lang="th" id="ntdotjsx.site" data-owner="ntdotjsx">
<a href="https://ntdotjsx.site">ntdotjsx.site</a>
</li>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major | ⚡ Quick win

Remove the old me.oreshi.com <li> to complete the replacement.

This PR adds ntdotjsx.site correctly, but me.oreshi.com is still present at Line 481-483, so the change is an append, not a replacement. Please delete the entire old <li> block to match the intended update and avoid stale entries.

Suggested fix
-        <li data-lang="th" id="me.oreshi.com" data-owner="somboytiger">
-          <a href="https://me.oreshi.com">me.oreshi.com</a>
-        </li>
         <li data-lang="th" id="ntdotjsx.site" data-owner="ntdotjsx">
           <a href="https://ntdotjsx.site">ntdotjsx.site</a>
         </li>

As per coding guidelines, “Remove identified entries from index.html by deleting the entire <li> elements for each site during cleanup,” and this PR objective explicitly describes a replacement.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@index.html` around lines 484 - 486, The PR adds the new ntdotjsx.site entry
but does not remove the old me.oreshi.com entry, making this an append rather
than a replacement. Locate and delete the entire li element block for
me.oreshi.com (which contains the href to me.oreshi.com) to complete the
replacement as intended. Ensure only the ntdotjsx.site li block remains after
the deletion.

Source: Coding guidelines

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant