fix(ui): remove duplicate mobile Discord button and improve drawer UX#309
Draft
RedStar071 wants to merge 2 commits into
Draft
fix(ui): remove duplicate mobile Discord button and improve drawer UX#309RedStar071 wants to merge 2 commits into
RedStar071 wants to merge 2 commits into
Conversation
Keep Sign in / Add App in the header for desktop only, and use a compact rounded Sign in control plus clearer spacing and destinations in the mobile navigation drawer. Co-authored-by: RedStar <redstar071@proton.me>
| { | ||
| description: "Tools to help you moderate your server", | ||
| label: "Moderation Tools", | ||
| to: "#moderation-tools", |
There was a problem hiding this comment.
The shared header appears on routes such as /staryl, /blog, and /login, but to="#moderation-tools" retains the current pathname. Those pages do not contain this section, so tapping the new menu item changes only the hash and does not navigate or scroll to the requested feature; the three links should include the WolfStar route.
Context Used: CLAUDE.md (source)
Prompt To Fix With AI
This is a comment left during a code review.
Path: app/composables/useHeader.ts
Line: 70
Comment:
**Hash Links Retain Wrong Route**
The shared header appears on routes such as `/staryl`, `/blog`, and `/login`, but `to="#moderation-tools"` retains the current pathname. Those pages do not contain this section, so tapping the new menu item changes only the hash and does not navigate or scroll to the requested feature; the three links should include the WolfStar route.
**Context Used:** CLAUDE.md ([source](https://app.greptile.com/wolfstar-project/github/wolfstar-project/wolfstar.rocks/-/custom-context?memory=d7db7ccf-40f4-43f6-9080-ac8602584fb3))
How can I resolve this? If you propose a fix, please make it concise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mdso the open mobile menu no longer shows a duplicate Discord icon next to the close buttonrounded-lgcontrol in the mobile drawerTest plan
mdupVerification
pnpm lint:fix— cleanpnpm typecheck— passpnpm test:unit— passpnpm build— pass (with test secrets + site URL)Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.Confidence Score: 4/5
Feature navigation from non-WolfStar routes needs a fix before merging.
The new hash-only links work on the WolfStar landing page. The shared header also exposes them on pages without the target elements, where they do not navigate or scroll. No security issues were found in the changed code.
app/composables/useHeader.ts
What T-Rex did
Prompt To Fix All With AI
Reviews (1): Last reviewed commit: "[autofix.ci] apply automated fixes" | Re-trigger Greptile