ci: install pinned cross release instead of git HEAD (fixes release builds)#6
Merged
Merged
Conversation
The release/docker workflows installed cross via `cargo install cross --git https://github.com/cross-rs/cross`. Building cross from git HEAD started failing on the runners: its `directories ^6.0` → `dirs-sys 0.5.0` dependency requires a newer toolchain than the action provides, so `cargo install` aborted with exit 101 before any project code was built. This broke "WolfDisk — Build Release Binaries" (and the docker + wolfscale release workflows share the same step). Switch to `cargo install cross --locked`, which installs the published cross 0.2.5 using its bundled lockfile (pinned, buildable deps). Validated locally: install succeeds and `cross build --release --target x86_64-unknown-linux-musl` runs. Applied to all three affected workflows. Co-Authored-By: CodeWolf <paul@wolf.uk.com> Co-Authored-By: Wolf Software Systems Ltd <paul@wolf.uk.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"WolfDisk — Build Release Binaries" (and the docker + wolfscale release workflows) started failing at the Install cross step — before any project code is built.
Root cause: they install cross with
cargo install cross --git https://github.com/cross-rs/cross. Building cross from git HEAD now pullsdirectories ^6.0→dirs-sys 0.5.0, which requires a newer toolchain than the runner provides, socargo installaborts with exit 101. The recentwolfdisk/s3merge merely re-triggered the workflow; the breakage is the unpinned git install.Fix
Use
cargo install cross --locked, which installs the published cross 0.2.5 with its bundled lockfile (pinned, buildable deps). Applied to all three affected workflows:.github/workflows/wolfdisk-release.yml.github/workflows/wolfdisk-docker-publish.yml.github/workflows/wolfscale-release.ymlValidation
cargo install cross --lockedruns to completion locally (the exact step that failed in CI).cross build --release --target x86_64-unknown-linux-muslof thewolfdiskcrate validated locally with Docker.Built by CodeWolf & Wolf Software Systems Ltd