replication: fix test build drift so cargo test compiles#5
Merged
Conversation
…, WalWriter) The wolfscale lib-test target failed to compile (5 errors) because test code had drifted from the current lib API. The library itself built fine, so this was only caught when running `cargo test`. - protocol.rs: `Message::Heartbeat` gained a `members: Vec<(String, String)>` field; add it to the test constructor and ignore it in the match pattern. - leader.rs: `LeaderNode::new` gained an 8th `executor: Option<Arc<MariaDbExecutor>>` argument; pass `None` in the test. - follower.rs: qualify `WalWriter` as `crate::wal::WalWriter` in the test (the type was never imported into this module). No production code changed — test-only fixes. `cargo test`: 44 passed. Co-Authored-By: CodeWolf <paul@wolf.uk.com> Co-Authored-By: Wolf Software Systems Ltd <paul@wolf.uk.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
wolfscalelib-test target failed to compile (5 errors), socargo testwas broken at the repo root. The library built fine, which is why it slipped through — the breakage was test code that had drifted from the current lib API.Fixes (test-only)
Message::Heartbeatgained amembers: Vec<(String, String)>field; added it to the test constructor and ignore it (..) in the match.LeaderNode::newgained an 8thexecutor: Option<Arc<MariaDbExecutor>>argument; passNonein the test.WalWriterascrate::wal::WalWriterin the test (the type was never imported into this module).No production code paths changed.
Testing
cargo test— 44 passed, 0 failed.Built by CodeWolf & Wolf Software Systems Ltd