Updated email to facts@wolfssl.com#10787
Conversation
stenslae
force-pushed
the
update-wolfssl-email
branch
from
44dec29 to
dad1e95
Compare
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10787
Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src
Findings: 1
High (1)
GEN_EMAIL test input array not updated to match new expected string
File: tests/api.c:20575
Function: test_wolfSSL_GENERAL_NAME_print
Category: Copy-paste errors
The email[] input array still encodes "info@wolfssl.com" while emailStr was changed to "email:facts@wolfssl.com". The GEN_EMAIL case prints "email:info@wolfssl.com", so the XSTRNCMP assertion at line 20751 returns nonzero and the test fails in OPENSSL_ALL builds.
Recommendation: Change the email[] array bytes to spell "facts@wolfssl.com" so the constructed GEN_EMAIL matches emailStr.
Referenced code: tests/api.c:20575-20579 (5 lines)
This review was generated automatically by Fenrir. Findings are non-blocking.
stenslae
force-pushed
the
update-wolfssl-email
branch
2 times, most recently
from
d26ca4b to
464df88
Compare
stenslae
force-pushed
the
update-wolfssl-email
branch
4 times, most recently
from
65fc5a4 to
691a22a
Compare
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10787
Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src
No new issues found in the changed files. ✅
stenslae
force-pushed
the
update-wolfssl-email
branch
from
691a22a to
92e76d4
Compare
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10787
Scan targets checked: wolfcrypt-bugs, wolfcrypt-port-bugs, wolfcrypt-rs-bugs, wolfcrypt-src, wolfssl-bugs, wolfssl-src
No new issues found in the changed files. ✅
2 participants
Description
Changed info@wolfssl.com to the live email, facts@wolfssl.com. Renewed certs to match.
NOTE: Also updated
certs/renewcerts.shto pin-des3so future cert regenerations match CI testing.