Testing: Guard RSA OversizedModulus test result by FIPS version#10779
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the RSA API unit test expectations to account for differing error codes returned by FIPS modules prior to v7 when exercising the “oversized modulus” path, keeping the test suite passing across FIPS versions (notably --enable-fips=v5).
Changes:
- Conditionally expect
RSA_OUT_OF_RANGE_Einstead ofWC_KEY_SIZE_Efor FIPS versions< 7.0in the oversized modulus test case. - Preserve the existing expectation (
WC_KEY_SIZE_E) for non-FIPS builds and FIPS>= 7.0.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dgarske
approved these changes
Jun 25, 2026
kareem-wolfssl
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
FIPS < v7 returns
RSA_OUT_OF_RANGE_Eon an Oversized ModulusTesting
./configure --enable-fips=v5 --enable-sp-math-all now passes unit tests
Checklist