CI: harden ci-deps-image downloads against stalled mirror connections#10729
Merged
Conversation
A single stalled apt mirror connection hung the ubuntu-24.04-full / ubuntu-22.04-full download for ~20 min (they normally finish in a few), tripping the 20-min job timeout and leaving those tags stale. The per-package retry() only re-runs on a non-zero exit, so a hang never tripped it. - apt drops a stalled connection after 30s and retries it (Acquire::http/https::Timeout, Acquire::Retries). - each apt-get is wrapped in `timeout` so a wedged process is hard-killed and retry() re-runs it from scratch. - raise the build job timeout 20 -> 60 min as a final backstop.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the ci-deps-image workflow against stalled apt mirror connections that can hang downloads long enough to hit the job timeout and leave ubuntu-22.04-full / ubuntu-24.04-full tags stale.
Changes:
- Adds
aptacquire timeouts and retry options to drop stalled connections quickly. - Wraps
apt-get updateand per-packageapt-get install --download-onlyintimeoutso hangs become retryable failures. - Increases the job-level timeout from 20 → 60 minutes as a final backstop.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
retest this please |
dgarske
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A single stalled apt mirror connection once hung the
ubuntu-24.04-full/ubuntu-22.04-fulldownload for ~20 min (they normally finish in a few),tripping the 20-min job timeout and leaving those tags stale. The per-package
retry()only re-runs on a non-zero exit, so a hang never tripped it.Defends in depth in
.github/workflows/ci-deps-image.yml:(
Acquire::http/https::Timeout,Acquire::Retries).apt-getis wrapped intimeoutso a wedged process is hard-killed andretry()re-runs it from scratch.