add macro guard around new test case for specific builds#10726
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adjusts the compile-time guards for the ECC shared-secret size-bounds API test so it is excluded from specific build configurations (notably certain WOLFSSL_SP_521 + FIPS/selftest combinations), preventing incompatible test compilation/execution in those environments.
Changes:
- Tightened the preprocessor conditions around
ecc_shared_secret_size_bound()andtest_wc_ecc_shared_secret_size_bounds()to additionally gate onWOLFSSL_SP_521in combination with FIPS version andHAVE_SELFTEST. - Kept the helper function and its corresponding test under matching guards to avoid unused/undefined references.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Retest this please Jenkins. FIPS 140-2 fail case. |
douzzer
approved these changes
Jun 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: