Skip to content

add macro guard around new test case for specific builds#10726

Merged
douzzer merged 2 commits into
wolfSSL:masterfrom
JacobBarthelmeh:test
Jun 18, 2026
Merged

add macro guard around new test case for specific builds#10726
douzzer merged 2 commits into
wolfSSL:masterfrom
JacobBarthelmeh:test

Conversation

@JacobBarthelmeh

@JacobBarthelmeh JacobBarthelmeh commented Jun 18, 2026

Copy link
Copy Markdown
Contributor

Fixes:

  • nightly QT test
  • FIPS v6 test with --enable-sp

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adjusts the compile-time guards for the ECC shared-secret size-bounds API test so it is excluded from specific build configurations (notably certain WOLFSSL_SP_521 + FIPS/selftest combinations), preventing incompatible test compilation/execution in those environments.

Changes:

  • Tightened the preprocessor conditions around ecc_shared_secret_size_bound() and test_wc_ecc_shared_secret_size_bounds() to additionally gate on WOLFSSL_SP_521 in combination with FIPS version and HAVE_SELFTEST.
  • Kept the helper function and its corresponding test under matching guards to avoid unused/undefined references.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@JacobBarthelmeh

Copy link
Copy Markdown
Contributor Author

Retest this please Jenkins. FIPS 140-2 fail case.

@JacobBarthelmeh JacobBarthelmeh added the For This Release Release version 5.9.2 label Jun 18, 2026
@douzzer douzzer merged commit 3876746 into wolfSSL:master Jun 18, 2026
302 of 303 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

For This Release Release version 5.9.2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants