additional sanity check on alert message size#10692
Merged
Merged
Conversation
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10692
Scan targets checked: wolfssl-bugs, wolfssl-src
No new issues found in the changed files. ✅
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds an additional bounds/sanity check when parsing TLS alert messages to avoid reading past the end of the input buffer.
Changes:
- Extends the alert-size validation in
DoAlertwith an input-buffer bounds check.
Comments suppressed due to low confidence (1)
src/internal.c:1
- The new bounds check can be bypassed via integer overflow in
*inOutIdx + ALERT_SIZEif*inOutIdxis near the max value of its type, potentially leading to an out-of-bounds read. Use an overflow-safe comparison (e.g., check*inOutIdx > length - ALERT_SIZEafter confirminglength >= ALERT_SIZE, or cast to a wider unsigned type and validate) to make the boundary check robust.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
dgarske
approved these changes
Jun 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://cloud.wolfssl-test.com/jenkins/job/fuzzer/job/fuzzer-with-com-det-sp-math-v2/2219/