-
Notifications
You must be signed in to change notification settings - Fork 998
Add RealTek AmebaPro2 (RTL8735B) HUK crypto-callback port #10677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
dgarske
wants to merge
1
commit into
wolfSSL:master
Choose a base branch
from
dgarske:realtek_huk
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,570
−2
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,86 @@ | ||
| name: RealTek RTL8735B (AmebaPro2) HUK port Tests | ||
|
|
||
| # START OF COMMON SECTION | ||
| on: | ||
| push: | ||
| branches: [ 'release/**' ] | ||
| pull_request: | ||
| types: [opened, synchronize, reopened, ready_for_review] | ||
| branches: [ '*' ] | ||
| # Weekday-morning cron seeds the master-scoped ccache that PR runs restore | ||
| # read-only (see ccache-setup). | ||
| schedule: | ||
| - cron: '27 10 * * 1-5' | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
| # END OF COMMON SECTION | ||
|
|
||
| jobs: | ||
| # Host compile-test of the RTL8735B HUK crypto-callback port. --enable-rtl8735b | ||
| # sets WOLFSSL_RTL8735B_HOST_TEST, which swaps the vendor HAL headers for | ||
| # rtl8735b_shim.h (sentinel stubs, no real crypto). So this is a build-only | ||
| # test: it exercises the crypto-callback dispatch, info-struct field access, | ||
| # compile guards, and build wiring without the RealTek SDK. Functional crypto | ||
| # validation requires RTL8735B hardware (see the port README). Configs span | ||
| # the algo/guard combinations and both WOLFSSL_SMALL_STACK branches of the | ||
| # HW-ECDSA helpers; build via .github/scripts/parallel-make-check.py (see | ||
| # cryptocb-only.yml / os-check.yml for the full pattern), one out-of-tree | ||
| # build dir per config off a single checkout/autogen. | ||
| build: | ||
| name: build (--enable-rtl8735b) | ||
| if: ${{ (github.repository_owner == 'wolfssl') && (github.event_name != 'pull_request' || github.event.pull_request.draft == false) }} | ||
| runs-on: ubuntu-24.04 | ||
| timeout-minutes: 15 | ||
| steps: | ||
| - uses: actions/checkout@v5 | ||
| name: Checkout wolfSSL | ||
|
|
||
| - name: Install dependencies | ||
| uses: ./.github/actions/install-apt-deps | ||
| with: | ||
| packages: autoconf automake libtool build-essential | ||
| ghcr-debs-tag: ubuntu-24.04-minimal | ||
|
|
||
| - name: Set up ccache | ||
| uses: ./.github/actions/ccache-setup | ||
| with: | ||
| workflow-id: rtl8735b | ||
| read-only: ${{ github.event_name == 'pull_request' }} | ||
| max-size: 100M | ||
|
|
||
| - name: Build all configs (compile-only, out-of-tree) | ||
| run: | | ||
| cat > "$RUNNER_TEMP/rtl8735b-configs.json" <<'EOF' | ||
| [ | ||
| {"name": "full-smallstack", "minutes": 2, | ||
| "comment": "All port paths (AES-GCM/ECB/CBC/CTR, HMAC-SHA256, ECDSA P-256) with WOLFSSL_SMALL_STACK -> exercises the heap branch of the HW-ECDSA mp_int helpers.", | ||
| "configure": ["--enable-rtl8735b", "--enable-cryptocb", "--enable-ecc", | ||
| "--enable-aesgcm", "--enable-aesctr", "--enable-aescbc", | ||
| "CPPFLAGS=-DWOLFSSL_SMALL_STACK"]}, | ||
| {"name": "full", "minutes": 2, | ||
| "comment": "Same algo coverage without WOLFSSL_SMALL_STACK -> exercises the on-stack (array) branch of the HW-ECDSA mp_int helpers.", | ||
| "configure": ["--enable-rtl8735b", "--enable-cryptocb", "--enable-ecc", | ||
| "--enable-aesgcm", "--enable-aesctr", "--enable-aescbc"]}, | ||
| {"name": "min", "minutes": 2, | ||
| "comment": "Minimal: no ECC (HW/SW ECDSA sign code compiled out), AES + HMAC only -> exercises the non-ECC compile guards.", | ||
| "configure": ["--enable-rtl8735b", "--enable-cryptocb"]} | ||
| ] | ||
| EOF | ||
| .github/scripts/parallel-make-check.py --build-only \ | ||
| "$RUNNER_TEMP/rtl8735b-configs.json" | ||
|
|
||
| - name: ccache stats | ||
| if: always() | ||
| run: ccache -s || true | ||
|
|
||
| - name: Upload logs on failure | ||
| if: failure() | ||
| uses: actions/upload-artifact@v6 | ||
| with: | ||
| retention-days: 7 | ||
| name: rtl8735b-logs | ||
| path: | | ||
| build-*/config.log | ||
| if-no-files-found: ignore |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.