Fenrir fixes#10136
Merged
Merged
Conversation
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10136
Scan targets checked: wolfcrypt-api_misuse, wolfcrypt-bugs, wolfcrypt-compliance, wolfcrypt-concurrency, wolfcrypt-port, wolfcrypt-port-bugs, wolfcrypt-portability, wolfcrypt-src
Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Findings are non-blocking.
4fdc3cf to
e866016
Compare
dgarske
reviewed
Apr 9, 2026
dgarske
left a comment
Member
There was a problem hiding this comment.
🐺 Skoll Code Review
Overall recommendation: APPROVE
Findings: 3 total — 3 posted, 2 skipped
Posted findings
- [Medium] Des3 CBC alignment check placed after crypto callback and async dispatch —
wolfcrypt/src/des3.c:1822,1877 - [Medium] No test coverage for new BAD_LENGTH_E alignment checks —
tests/api/test_camellia.c, tests/api/test_des3.c, tests/api/test_rc2.c - [Low] DoBase64_Encode NULL check placed after arithmetic on inLen —
wolfcrypt/src/coding.c:480-484
Skipped findings
- [Medium] Des3 CBC alignment check placed after crypto callback and async dispatch
- [Medium] No test coverage for new BAD_LENGTH_E alignment checks
Review generated by Skoll via openclaw
e866016 to
3aa9a58
Compare
Contributor
Author
|
Jenkins retest this please |
dgarske
approved these changes
Apr 15, 2026
SparkiDev
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes F-1916, F-1907, F-1911, F-1915, F-1909, F-1913, F-1914