Add bounds checks for MP integer size in SizeASN_Items#10051
Merged
Conversation
Member
|
Jenkins retest this please -history lost |
Member
Author
|
Jenkins retest this please. Unable to get pull request trigger. |
Member
Author
|
Jenkins retest this please Build was aborted |
Member
Author
|
jenkins retest this please remote hung up. |
Member
Author
|
jenkins retest this please ABORTED |
Member
Author
|
jenkins retest this please. |
Member
Author
|
Jenkins retest this please. |
1 similar comment
Member
Author
|
Jenkins retest this please. |
Member
Author
|
jenkins retest this please Not found. |
Member
Author
|
Jenkins retest this please. |
Member
Author
|
jenkins retest this please. |
Member
Author
|
jenkins retest this please. |
SparkiDev
reviewed
Apr 9, 2026
dgarske
reviewed
Apr 9, 2026
dgarske
left a comment
dgarske
left a comment
Member
There was a problem hiding this comment.
🐺 Skoll Code Review
Overall recommendation: APPROVE
Findings: 3 total — 3 posted, 0 skipped
Posted findings
- [Medium] SetASN_Items MP path lacks matching bounds checks —
wolfcrypt/src/asn.c:1097-1099 - [Medium] Test only covers USE_INTEGER_HEAP_MATH; tfm.c has same overflow pattern —
tests/api/test_rsa.c:1161-1163 - [Low] Unused variable derRet could use (void) cast or direct use in Expect —
tests/api/test_rsa.c:1254-1255
Review generated by Skoll via openclaw
Member
Author
|
jenkins retest this please |
|
Member
Author
|
jenkins retest this please |
Member
Author
|
Jenkins retest this please |
Member
Author
|
Good to go. @wolfSSL-Bot , please sqash and merge at will. |
douzzer
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ZD 21401