Repository navigation
Conversation
Travis CI has not run this project in years and no runner has Python 3.6 anymore. The workflow installs through pipenv and runs black, pylint (errors only) and a byte-compile on every push and pull request. gunicorn 23.0.0, rq 1.16.2 and APScheduler 3.10.4: the 3.6 release imported pkg_resources, which Python 3.12 environments no longer ship. redis is listed since the code imports it directly. black joins the dev packages because the badge claims it. The pylint config gains the section header pylint 3 requires.
…ger raises The scheduler enqueued on database 0 while the worker listened on database 1, so with default settings no job ever ran. Both read REDIS_DB now. _minion_info returned an unbound name when the highstate result was empty. The salt imports carry a pylint marker: salt is the master host's package, not a dependency the lint job can install.
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unresolved CI branch, Redis deployment, and Python/Salt compatibility issues block approval.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 3
Open (5)
What changed in this PR
Merges develop into main while modernizing Python support, CI, dependencies, Redis configuration, documentation, and licensing.
Changes:
- Adds GitHub Actions CI and updates development tooling.
- Updates Python and dependency configuration.
- Aligns Redis database settings.
- Refreshes documentation, changelog, and license.
| File | Description |
|---|---|
worker.py |
Adds configurable Redis database selection. |
tasks.py |
Reformats a docstring. |
smonit/tasks.py |
Formatting adjustment. |
smonit/services/api.py |
Handles Salt imports and initializes result values. |
smonit/main.py |
Formatting cleanup. |
smonit/execution.py |
Adds Redis database configuration. |
smonit/__init__.py |
Formatting cleanup. |
README.md |
Updates setup, usage, and configuration documentation. |
pyproject.toml |
Targets Python 3.12 for Black. |
Pipfile.lock |
Regenerates locked dependencies. |
Pipfile |
Updates dependencies and Python requirements. |
LICENSE |
Changes the license to Apache 2.0. |
CHANGELOG.md |
Documents release changes. |
.travis.yml |
Removes obsolete Travis CI configuration. |
.pylintrc |
Updates Pylint configuration. |
.github/workflows/ci.yml |
Adds GitHub Actions checks. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
…for pushes to main' Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…ilable to systemd runtime commands' Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…alt runs on smonit imports salt from its own interpreter, so it can only run on a Python that Salt supports. Every current Salt release, 3008.2 included, advertises 3.8 to 3.10 and the official packages bundle 3.10, so 3.12 was a requirement no salt-master host could meet. The lock is regenerated on 3.10 and the README says how to install into the onedir Python with salt-pip.
… are enqueued The bare rq command ignored REDIS_DB and sat on database 0 while the scheduler enqueued on database 1. The environment file now spells out the port and database too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.