Skip to content

feat: dashboard host page: since the previous scan - #314

Merged
with-developer merged 3 commits into
mainfrom
feat/host-since-last-scan
Nov 20, 2026
Merged

with-developer merged 3 commits into
mainfrom
feat/host-since-last-scan

Conversation

@with-developer

@with-developer with-developer commented Nov 20, 2026 •

Copy link
Copy Markdown
Owner

The second step of the dashboard redesign: a host's page starts with what changed since its previous scan.

What

  • Since the previous scan (above the tabs, when the host has two scans): the controls that got worse or were fixed between the previous scan and the latest one, with the status before and after ("checks changed" when the control's status stayed but one of its checks got worse). Clicking one switches to the controls tab, makes sure its status is shown, opens it and moves the focus to it. "Compare the two scans" opens the full comparison in the history tab. Up to 8 rows, then a count of the other changes.
  • The controls list marks the controls that got worse with a "Worse" tag.
  • With a profile chosen, the card lists only that profile's controls (the comparison itself covers the whole scans).
  • It uses the existing /api/v1/diff; no server change. The live demo already records the diff of each pair of adjacent scans.
  • Fixed on the way: the count on the selected FAIL filter chip had a contrast of 3.94:1 (white on light red); its background is now darker (axe clean).

Tests

  • make test lint, make build-web.
  • axe clean and no horizontal overflow on a host page in en/ko × light/dark × 1280/390 against vmsctl server demo; a click on a change opens that control and focuses it (checked in the browser).
  • Screenshots of the host page regenerated (README, site en/ko); docs/fleet.md (and .ko) describe the overview and the host page as they are now.

Review (/code-review medium)

Fixed:

  • The selected tab was lost when the page reloaded after "Scan now" (it had moved inside the part that unmounts on reload); it lives outside it again.
  • "Compare the two scans" did nothing on a second click after closing the comparison; every click now opens it, and the page scrolls to it (it sits below the chart and the scan list).
  • The control picked from the card was re-applied every time the controls tab mounted again (clearing the search, reopening, scrolling); it is applied once, and the scroll happens only for that pick.
  • With a profile chosen, "N more changes" counted controls of other profiles; every list is now limited to the shown profile.
  • When the previous scan checked other controls (another profile, a new revision), the card said "Nothing got worse or was fixed"; it now says the previous scan checked other controls and points at the comparison.
  • The scan-list reset in History (dead after the reload change) is removed.

Not changed:

  • One /api/v1/diff per host page view (two stored results read and compared on the server): it is the comparison vmsctl diff makes, with check-level changes ("checks changed"), which scan_controls alone does not have. A cheaper path can come if host pages get slow.
  • The chip count contrast fix stays in this PR: the host page is what this PR checks with axe, and the failure was on it (3.94:1); dark mode stays clean.

…ious scan, opening the control from the list
…ens once, compare works every time and scrolls to the comparison, the card counts only the shown profile and says when the previous scan checked other controls
@with-developer
with-developer merged commit 1538ada into main Nov 20, 2026
9 checks passed
@with-developer
with-developer deleted the feat/host-since-last-scan branch November 20, 2026 09:22
with-developer added a commit that referenced this pull request Nov 20, 2026
Install commands and image tags in the README, the CI and container
guides and the project page now name v0.44.0; the translation marker of
docs/fleet.ko.md points at the squash commit of #314 (1538ada).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant