Repository navigation
feat: dashboard host page: since the previous scan - #314
Merged
Merged
Conversation
…ious scan, opening the control from the list
…ens once, compare works every time and scrolls to the comparison, the card counts only the shown profile and says when the previous scan checked other controls
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The second step of the dashboard redesign: a host's page starts with what changed since its previous scan.
What
/api/v1/diff; no server change. The live demo already records the diff of each pair of adjacent scans.Tests
make test lint,make build-web.vmsctl server demo; a click on a change opens that control and focuses it (checked in the browser).docs/fleet.md(and.ko) describe the overview and the host page as they are now.Review (
/code-review medium)Fixed:
Not changed:
/api/v1/diffper host page view (two stored results read and compared on the server): it is the comparisonvmsctl diffmakes, with check-level changes ("checks changed"), whichscan_controlsalone does not have. A cheaper path can come if host pages get slow.