Skip to content

feat: dashboard overview: fix first, recent changes, hosts at a glance - #312

Merged
with-developer merged 3 commits into
mainfrom
feat/overview-fix-first
Nov 19, 2026
Merged

with-developer merged 3 commits into
mainfrom
feat/overview-fix-first

Conversation

@with-developer

@with-developer with-developer commented Nov 19, 2026 •

Copy link
Copy Markdown
Owner

The first step of the dashboard redesign: the overview now says what to fix first and what just changed, instead of only showing numbers.

What

  • Fix first: the failing controls ranked by severity × failing hosts (high counts 3, medium 2, low 1), each with what fixing it on every failing host adds to the fleet's pass rate (percentage points), and a "How to fix" link to the control page. Under the score: "Fixing the top 3 raises the pass rate to N%".
  • Recent changes: one list, newest first, of controls that got worse (regressions), controls that were fixed (new: latest scan PASS or N/A where the previous one was FAIL or ERROR), and hosts that stopped reporting; each kind keeps a share so a burst of regressions does not hide the rest.
  • Hosts at a glance: every host as a tile with its pass rate, worst first.
  • API: /api/v1/overview gains topFailing[].gain and recentFixes (additive; the old fields are unchanged except the order of topFailing, which is now severity-weighted).

Tests

  • TestOverviewGainAndFixes: the gain formula, no fixes before a second scan, and a fixed control showing up as a fix and leaving the regressions.
  • make test lint, make build-web; axe clean and no horizontal overflow in en/ko × light/dark × 1280/390 against vmsctl server demo.
  • Screenshots regenerated (README, site en/ko).

Review (/code-review medium)

Fixed in c410a64:

  • Gains were rounded to one decimal on the server, so a control failing on a few hosts in a large fleet got 0 and lost its badge and the top-3 sentence. The API now sends three decimals; the dashboard shows one (two for a gain under 0.1).
  • MAX(severity) compared strings, so a control reported as high on some hosts and medium on others ranked as medium. The weight is now the highest severity, and so is the shown severity.
  • Regressions and fixes are one query (the scan window once, not twice). ERROR to PASS is no longer a fix: the check ran again, nothing was changed.
  • Silent hosts came from the 60 worst-scoring hosts, so a silent host with a good score never showed; they now have their own query.
  • A regression to ERROR carries an ERROR badge, so it does not read as a failure.
  • The top-3 sentence is hidden when the lift does not change the shown percentage.
  • Dead CSS of the old cards removed; a silent row no longer shows its age twice.
  • New test TestOverviewFixFirstOrder (severity × hosts, mixed severities); the fixes test covers ERROR to PASS.

Not changed: the .ko.md markers point at the branch commit, as before; they are moved to the squash commit in the next docs change, as #310 did for #309.

…, recent changes (worse, fixed, silent), hosts at a glance
…, one query for regressions and fixes (ERROR to PASS is not a fix), silent hosts from their own query, ERROR badge, dead CSS
@with-developer
with-developer merged commit 4489718 into main Nov 19, 2026
20 checks passed
@with-developer
with-developer deleted the feat/overview-fix-first branch November 19, 2026 09:26
with-developer added a commit that referenced this pull request Nov 19, 2026
Install commands and image tags in the README, the CI and container
guides and the project page now name v0.43.0; the translation markers of
README.ko.md and docs/fleet.ko.md point at the squash commit of #312
(4489718).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant