Repository navigation
feat: dashboard overview: fix first, recent changes, hosts at a glance - #312
Merged
Merged
Conversation
…, recent changes (worse, fixed, silent), hosts at a glance
…, one query for regressions and fixes (ERROR to PASS is not a fix), silent hosts from their own query, ERROR badge, dead CSS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first step of the dashboard redesign: the overview now says what to fix first and what just changed, instead of only showing numbers.
What
/api/v1/overviewgainstopFailing[].gainandrecentFixes(additive; the old fields are unchanged except the order oftopFailing, which is now severity-weighted).Tests
TestOverviewGainAndFixes: the gain formula, no fixes before a second scan, and a fixed control showing up as a fix and leaving the regressions.make test lint,make build-web; axe clean and no horizontal overflow in en/ko × light/dark × 1280/390 againstvmsctl server demo.Review (
/code-review medium)Fixed in c410a64:
MAX(severity)compared strings, so a control reported as high on some hosts and medium on others ranked as medium. The weight is now the highest severity, and so is the shown severity.TestOverviewFixFirstOrder(severity × hosts, mixed severities); the fixes test covers ERROR to PASS.Not changed: the
.ko.mdmarkers point at the branch commit, as before; they are moved to the squash commit in the next docs change, as #310 did for #309.