Skip to content

docs: D75, the three decisions before 1.0, and the notices in the crates - #170

Merged
with-developer merged 1 commit into
mainfrom
docs/d75-decisions
Nov 19, 2026
Merged

with-developer merged 1 commit into
mainfrom
docs/d75-decisions

Conversation

@with-developer

Copy link
Copy Markdown
Owner

Purpose

Issue #165 put three choices to the maintainer, who left them to their agent on 2026-11-19. D75 records the decisions with their reasons and what was not chosen, and the third is done in this PR.

Changes

  • ARCHITECTURE.md D75: (1) the shared library's name carries the crate's major version (implemented in a following PR); (2) emberwave-wgpu is split out of emberwave-core, with the inventory and the data (10,325 lines of GPU code against 6,934 of core, six pub(crate) items to open, the dependents, the tests, the order of the work, the risks), no code moves; (3) THIRD_PARTY_NOTICES.md goes into both crates.
  • crates/emberwave-core/THIRD_PARTY_NOTICES.md and crates/emberwave-cli/THIRD_PARTY_NOTICES.md, copies of the root file; cargo package --list -p emberwave-core -p emberwave-cli now lists them. scripts/check_license_copies.sh, a new step of the lint job, fails when a copy of LICENSE or of the notices differs from the root's.
  • CONTRIBUTING, D74's "Not done" and the README's 1.0 checklist (English and Korean) say what is decided and still to do.

What it changes for a client

Nothing in the libraries. The notices reach crates.io with the next publish, which needs the maintainer's approval. To revert, delete the two copies and the script.

Testing

scripts/check_license_copies.sh passes; cargo package --list shows the notices in both crates. Docs, two copied files, one script and one CI step.

Issue #165 put three choices to the maintainer, who left them to their agent.
D75 records them: the shared library's name will carry the crate's major
version (its own PR follows); `emberwave-wgpu` will be split out of
`emberwave-core` so that the core has no wgpu type in its API, with the
inventory, the six core items the move has to open, the dependents, the
tests, the order of the work and the risks (no code moves yet); and
THIRD_PARTY_NOTICES.md goes into both crates.

The third is done here: the notices are copied next to LICENSE into
emberwave-core and emberwave-cli (`cargo package --list` shows them),
scripts/check_license_copies.sh, a step of the lint job, keeps the copies
equal to the root's, and CONTRIBUTING and D74 say so. They reach crates.io
with the next publish, which needs the maintainer's approval. The README's
1.0 checklist says what is decided and still to do.

Claude-Session: https://claude.ai/code/session_019fJGoCTvP5e7n599q3ZQ42
@with-developer
with-developer merged commit fc92612 into main Nov 19, 2026
7 checks passed
@with-developer
with-developer deleted the docs/d75-decisions branch November 19, 2026 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant