[austinderrick]

Summary

Cms\Classes\CodeParser writes the generated class for a page's PHP code section to a fixed path, but gives the class a new random name on every rebuild. Both rebuild() and source() loaded that file with require_once, which keys on the path, so a process that had already loaded the path skipped every later version of the file and the page failed:

Error: Class "Cms<hash>Class" not found

The later version can come from the same process or from another one. With several long-running workers (Laravel Octane, or queue workers rendering pages), worker B's rebuild is skipped by worker A, whose handleCorruptCache() then deletes and rebuilds the file, which invalidates worker B in turn. The workers keep rebuilding each other after every edit, and a third worker can hit the file while it is missing.

All three paths now load the file through requireClassFile(), which reads the class name the file declares and uses require only when that class is not loaded yet. require therefore never redeclares a class, and a new version of the file is always loaded. PHP-FPM behavior does not change, since each request starts with nothing loaded.

Split out of #1511 so it can be reviewed on its own.

Testing

modules/cms/tests/classes/CodeParserRebuildTest.php covers two rebuilds in one process and a rebuild written by another process (same path, new class name) that source() must load. Both fail without the change. The full CMS module suite passes (221 tests).

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: a4563ac9-e329-4265-875c-93a826892b24

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}