[austinderrick]

Summary

Storm aliases the log service to Illuminate\Log\Logger, but the service is a LogManager, and Laravel aliases it to LogManager. With no LogManager alias, app(LogManager::class) tries to build a new LogManager and fails on its untyped $app parameter. Laravel's HandleExceptions::handleDeprecationError() resolves the logger that way and swallows the exception, so a Winter application never logs a PHP deprecation, whatever logging.deprecations says. The alias now names LogManager, as Laravel's does.

The alias was copied from Laravel 5.5, where the service was a Writer, and became Logger in b6ebe0d during the Laravel 6 upgrade, but the service has been a LogManager since Laravel 5.6. October CMS made the same fix in octobercms/library@06fa70af.

Testing

testLogManagerResolvesToTheLogService in tests/Foundation/CoreContainerAliasesTest.php fails without the change. The full suite passes on PHP 8.5.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Advanced
• Run ID: 09176162-748c-4462-b630-bf73974af1d2

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}