Added years logic#25
Open
KieranDotCo wants to merge 1 commit into
Open
Conversation
Owner
|
Hey, thanks for this! I'm all for supporting "X years ago". There's not any particular reason for why it was missing. There are a bunch of applications that use this filter and I don't want to potentially break their UI, so I'm wondering how we can merge this without negatively affecting existing users of this filter. I guess we could:
What do you think? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current filter there is no logic for working out 'X years ago', I've made a change and modified tests, feel free to close if there is a reason that support for 'X years ago' doesn't exist.